i18n(zh-TW): Adds Chinese (Traditional) translation by ayfl269 · Pull Request #559 · emdash-cms/emdash

ayfl269 · 2026-04-14T12:47:47Z

What does this PR do?

Adds Chinese (Traditional) (zh-TW) translation for the admin UI. This includes:

Complete message catalog for zh-TW locale
Enables zh-TW as a selectable locale in the admin UI
Adds locale configuration and test coverage

Closes #

Type of change

Checklist

I have read https://github.com/emdash-cms/emdash/blob/main/CONTRIBUTING.md
pnpm typecheck passes
pnpm lint passes
pnpm test passes (or targeted tests for my change)
pnpm format has been run
I have added/updated tests for my changes (if applicable)
User-visible strings in the admin UI are https://github.com/emdash-cms/emdash/blob/main/CONTRIBUTING.md#internationalization-i18n and pnpm locale:extract has been run (if applicable)
I have added a https://github.com/emdash-cms/emdash/blob/main/CONTRIBUTING.md#changesets (if this PR changes a published package)
New features link to an approved Discussion: https://github.com/emdash-cms/emdash/discussions/...

AI-generated code disclosure

This PR includes AI-generated code

Screenshots / test output

N/A - Translation add only, no visual changes or functional modifications.

changeset-bot · 2026-04-14T12:47:53Z

🦋 Changeset detected

Latest commit: 00177c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
@emdash-cms/admin	Patch
emdash	Patch
@emdash-cms/cloudflare	Patch
@emdash-cms/auth	Patch
@emdash-cms/blocks	Patch
@emdash-cms/gutenberg-to-portable-text	Patch
@emdash-cms/x402	Patch
create-emdash	Patch
@emdash-cms/plugin-embeds	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-04-14T12:47:59Z

Scope check

This PR changes 5,525 lines across 4 files. Large PRs are harder to review and more likely to be closed without review.

If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs.

See CONTRIBUTING.md for contribution guidelines.

pkg-pr-new · 2026-04-14T12:49:19Z

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@559

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@559

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@559

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@559

emdash

npm i https://pkg.pr.new/emdash@559

create-emdash

npm i https://pkg.pr.new/create-emdash@559

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@559

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@559

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@559

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@559

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@559

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@559

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@559

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@559

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@559

commit: 00177c5

ascorbic · 2026-04-14T15:36:02Z

-	test("falls back to base language (zh-TW -> zh-CN)", () => {
-		expect(resolveLocale(makeRequest({ "accept-language": "zh-TW" }))).toBe("zh-CN");
+	test("matches exact accept-language tag with region (zh-TW)", () => {
+		expect(resolveLocale(makeRequest({ "accept-language": "zh-TW" }))).toBe("zh-TW");


This needs to be changed to another language pair so it can test fallback logic. pt-PT/pt-BR would be my suggestion

Copilot

Pull request overview

Adds a new Traditional Chinese (zh-TW) locale to the admin UI i18n system, updating locale resolution behavior/tests and introducing a full PO catalog so the locale can be selected at runtime.

Changes:

Adds zh-TW to the admin’s canonical locale list and enables it in the UI.
Updates resolveLocale() tests to expect exact Accept-Language: zh-TW matching.
Introduces a full zh-TW Lingui PO catalog and a changeset for @emdash-cms/admin.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File	Description
packages/admin/tests/lib/locales.test.ts	Updates locale negotiation test coverage for zh-TW `Accept-Language` matching.
packages/admin/src/locales/zh-TW/messages.po	Adds the Traditional Chinese translation catalog.
packages/admin/src/locales/locales.ts	Adds `zh-TW` as an enabled locale definition.
.changeset/i18n-zh-tw-translation.md	Publishes the change as a patch release for `@emdash-cms/admin`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Added support for matching Chinese script codes (zh-Hant, zh-Hans), enabling mapping zh-Hant to zh-TW and zh-Hans to zh-CN.

Removed tests for various Chinese locale matching scenarios.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Add SCRIPT_LANGUAGE_MAP and populate script-to-locale mappings (e.g. zh-Hant -> zh-TW, zh-Hans -> zh-CN) while building supported locales. Extend matchLocale to check exact matches, then try script-based matching using Intl.Locale.script, and finally fall back to the base-language map. Keeps existing canonicalization via Intl.Locale and base-language fallback behavior.

ascorbic · 2026-04-14T18:43:02Z

+	// Build script mapping for Chinese locales
+	if (l.code === "zh-TW") {
+		SCRIPT_LANGUAGE_MAP.set("zh-hant", "zh-TW");
+	} else if (l.code === "zh-CN") {
+		SCRIPT_LANGUAGE_MAP.set("zh-hans", "zh-CN");
+	}


Suggested change

// Build script mapping for Chinese locales

if (l.code === "zh-TW") {

SCRIPT_LANGUAGE_MAP.set("zh-hant", "zh-TW");

} else if (l.code === "zh-CN") {

SCRIPT_LANGUAGE_MAP.set("zh-hans", "zh-CN");

}

const maximized = new Intl.Locale(l.code).maximize();

if (maximized.script) {

const scriptKey = `${maximized.language}-${maximized.script}`.toLowerCase();

if (!SCRIPT_LANGUAGE_MAP.has(scriptKey)) {

SCRIPT_LANGUAGE_MAP.set(scriptKey, l.code);

}

}

Rather than hard-coding, you can use maximize()

Refactor Chinese locale mapping to use Intl.Locale for script handling.

ascorbic

Great work, thanks

ayfl269 and others added 12 commits April 13, 2026 21:47

i18n(zh-CN): Update Simplified Chinese translation

f45a477

Merge branch 'emdash-cms:main' into main

c9df488

Merge branch 'emdash-cms:main' into main

a2ffd6c

Merge branch 'emdash-cms:main' into main

6894a2b

Merge branch 'emdash-cms:main' into main

8903ac2

i18n(zh-CN): Update Chinese (Simplified) translation

e382946

Merge branch 'emdash-cms:main' into main

19c0b97

Merge branch 'emdash-cms:main' into main

42f80f4

Merge branch 'emdash-cms:main' into main

c949fd0

i18n(zh-TW): Adds Chinese (Traditional) translation

cc22c24

i18n(zh-TW): Adds Chinese (Traditional) translation

1994e30

Merge branch 'main' of https://github.com/ayfl269/emdash

e33c258

github-actions bot added area/admin size/XL labels Apr 14, 2026

github-actions bot added the cla: signed label Apr 14, 2026

ascorbic requested a review from Copilot April 14, 2026 15:34

Copilot started reviewing on behalf of ascorbic April 14, 2026 15:35 View session

ascorbic reviewed Apr 14, 2026

View reviewed changes

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread packages/admin/tests/lib/locales.test.ts

ayfl269 and others added 6 commits April 15, 2026 00:18

feat(locales): Supports localized matching of Chinese script code.

793be8f

Added support for matching Chinese script codes (zh-Hant, zh-Hans), enabling mapping zh-Hant to zh-TW and zh-Hans to zh-CN.

Remove redundant Chinese locale tests

e4a603f

Removed tests for various Chinese locale matching scenarios.

Apply suggestions from code review

793daaa

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into main

3fb7ef9

style: format

659a889

ascorbic reviewed Apr 14, 2026

View reviewed changes

Update locale script mapping logic

023489c

Refactor Chinese locale mapping to use Intl.Locale for script handling.

style: format

00177c5

ascorbic approved these changes Apr 15, 2026

View reviewed changes

ascorbic merged commit a2d5afb into emdash-cms:main Apr 15, 2026
26 checks passed

emdashbot bot mentioned this pull request Apr 15, 2026

ci: release #560

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

i18n(zh-TW): Adds Chinese (Traditional) translation#559

i18n(zh-TW): Adds Chinese (Traditional) translation#559
ascorbic merged 20 commits intoemdash-cms:mainfrom
ayfl269:main

ayfl269 commented Apr 14, 2026

Uh oh!

changeset-bot bot commented Apr 14, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 14, 2026

Uh oh!

pkg-pr-new bot commented Apr 14, 2026 •

edited

Loading

Uh oh!

ascorbic Apr 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

ascorbic Apr 14, 2026

Uh oh!

ascorbic left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ayfl269 commented Apr 14, 2026

What does this PR do?

Type of change

Checklist

AI-generated code disclosure

Screenshots / test output

Uh oh!

changeset-bot bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Apr 14, 2026

Scope check

Uh oh!

pkg-pr-new bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ascorbic Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

ascorbic Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

ascorbic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Apr 14, 2026 •

edited

Loading

pkg-pr-new bot commented Apr 14, 2026 •

edited

Loading