fix(admin): use dropdown for login page language selector#564
Merged
Conversation
🦋 Changeset detectedLatest commit: 4e0509b The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the admin login page language selector to use the Kumo Select dropdown (matching the Settings page behavior) and standardizes @cloudflare/kumo to a single workspace-catalog version so admin/blocks share the same dependency version.
Changes:
- Replace the login page’s inline locale button bar with a
Selectdropdown backed bySUPPORTED_LOCALES. - Add
@cloudflare/kumoto the workspacecatalogand switch dependent packages tocatalog:to unify versions. - Add a changeset for the admin UI patch release.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adds @cloudflare/kumo to the pnpm catalog for centralized versioning. |
| pnpm-lock.yaml | Updates lockfile to use Kumo 1.18.0 and switches importers to catalog:. |
| packages/blocks/playground/package.json | Moves Kumo dependency to catalog: for version alignment. |
| packages/blocks/package.json | Moves Kumo dependency to catalog: for version alignment. |
| packages/admin/package.json | Moves Kumo dependency to catalog: for version alignment. |
| packages/admin/src/components/LoginPage.tsx | Replaces button-based language selector with Kumo Select. |
| .changeset/forty-facts-deny.md | Declares a patch release for @emdash-cms/admin reflecting the UI change. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-playground | 4e0509b | Apr 15 2026, 07:12 AM |
Contributor
Overlapping PRsThis PR modifies files that are also changed by other open PRs:
This may cause merge conflicts or duplicated work. A maintainer will coordinate. |
Open
The inline button bar didn't scale past a handful of locales. Swap it for the same kumo Select dropdown used in Settings.
ascorbic
force-pushed
the
fix/login-language-selector-dropdown
branch
from
976d199 to
4e0509b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The login page's language selector rendered every supported locale as an inline button with dot separators. That worked when there were three locales; with the current nine (and more coming) it wraps awkwardly and is hard to scan. This PR swaps it for the same kumo
Selectdropdown already used for the language setting in Settings, so the affordance is consistent and scales.Also bumps
@cloudflare/kumoto the workspace catalog (^1.18.0) so@emdash-cms/adminand@emdash-cms/blocksshare a single version and pick up theSelectcomponent.Closes #
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runpnpm locale:extracthas been run (if applicable)AI-generated code disclosure
Screenshots / test output
Verified
pnpm --filter @emdash-cms/admin typecheckandpnpm lint:quickclean on the touched file.