fix(core): actionable error for stale better-sqlite3 native binary#582
Merged
ascorbic merged 2 commits intoemdash-cms:mainfrom Apr 15, 2026
Merged
Conversation
… stale When Node.js is upgraded without rebuilding native deps, better-sqlite3 throws a NODE_MODULE_VERSION mismatch that createDatabase surfaces only as a generic "Failed to create database". Detect this specific case and tell the user to rebuild or reinstall the native module. Closes emdash-cms#562 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 23d54cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When Node.js is upgraded (or
node_moduleswas built with a different Node version),better-sqlite3fails to load with aNODE_MODULE_VERSIONmismatch. Today,createDatabasecatches this and surfaces a genericFailed to create database— the real cause is only visible if the user digs into thecause.This PR detects the
NODE_MODULE_VERSIONstring in the underlying error and throws anEmDashDatabaseErrorwhose message tells the user exactly what to do: rebuild the native module withpnpm rebuild better-sqlite3(or reinstall deps).The helper is exported and covered by unit tests.
Closes #562
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runpnpm locale:extracthas been run (if applicable)AI-generated code disclosure
Screenshots / test output