Skip to content

Added a Korean i18n#592

Merged
ascorbic merged 2 commits intoemdash-cms:mainfrom
asdfgl98:i18n/ko
Apr 16, 2026
Merged

Added a Korean i18n#592
ascorbic merged 2 commits intoemdash-cms:mainfrom
asdfgl98:i18n/ko

Conversation

@asdfgl98
Copy link
Copy Markdown
Contributor

@asdfgl98 asdfgl98 commented Apr 16, 2026

What does this PR do?

Added a Korean locale for the admin page.

The initial draft was generated with Codex 5.4 High, followed by a second-pass review with Claude Opus 4.6.
I then manually refined the translations to fix wording that was too literal, unnatural, or incorrect, and completed a final verification in the admin UI.

I’m very interested in this project and am actively using it, so I expect to continue submitting Korean localization PRs.
I also plan to keep translating newly added sections as they are introduced.

Closes #

Type of change

  • Bug fix
  • Feature (requires maintainer-approved Discussion)
  • Refactor (no behavior change)
  • Translation
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • User-visible strings in the admin UI are wrapped for translation and pnpm locale:extract has been run (if applicable)
  • I have added a changeset (if this PR changes a published package)
  • New features link to an approved Discussion: https://github.com/emdash-cms/emdash/discussions/...

AI-generated code disclosure

  • This PR includes AI-generated code

Screenshots / test output

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 16, 2026

🦋 Changeset detected

Latest commit: 1b4bbc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@emdash-cms/admin Patch
emdash Patch
@emdash-cms/cloudflare Patch
@emdash-cms/auth Patch
@emdash-cms/blocks Patch
@emdash-cms/gutenberg-to-portable-text Patch
@emdash-cms/x402 Patch
create-emdash Patch
@emdash-cms/plugin-embeds Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@github-actions
Copy link
Copy Markdown
Contributor

Scope check

This PR changes 5,522 lines across 3 files. Large PRs are harder to review and more likely to be closed without review.

If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs.

See CONTRIBUTING.md for contribution guidelines.

@asdfgl98
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Apr 16, 2026
Copy link
Copy Markdown
Collaborator

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ascorbic ascorbic enabled auto-merge (squash) April 16, 2026 07:22
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 16, 2026

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@592

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@592

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@592

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@592

emdash

npm i https://pkg.pr.new/emdash@592

create-emdash

npm i https://pkg.pr.new/create-emdash@592

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@592

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@592

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@592

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@592

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@592

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@592

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@592

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@592

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@592

commit: 1b4bbc9

@ascorbic ascorbic merged commit 6c92d58 into emdash-cms:main Apr 16, 2026
26 of 29 checks passed
@emdashbot emdashbot bot mentioned this pull request Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants