fix(import): surface real error messages in WordPress import failures#598
Merged
ascorbic merged 1 commit intoemdash-cms:mainfrom Apr 16, 2026
Merged
Conversation
…emdash-cms#553) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 3c0c804 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Surfaces real exception messages in WordPress import errors instead of the generic
"Failed to import item"string.Problem
Both WordPress import paths catch per-item exceptions and replace them with a hardcoded
"Failed to import item"string before adding them to the result. The actual error message is logged to the server console viaconsole.error, but discarded from the API response.This makes issues like #553 (where all 185 items failed) nearly impossible to diagnose remotely — every error in the admin UI looks identical regardless of root cause.
Change
Replace the hardcoded string with the actual
error.message, falling back to"Failed to import item"only when no message is available:Scope
Intentionally narrow. This does not fix #553 — it makes #553 (and future import failures) diagnosable so the root cause can be identified from user reports.
Files
packages/core/src/astro/routes/api/import/wordpress-plugin/execute.tspackages/core/src/astro/routes/api/import/wordpress/execute.tsRefs #553
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runpnpm locale:extracthas been run (if applicable)AI-generated code disclosure
Screenshots / test output
N/A — server-side change only. Error messages that were previously swallowed will now appear in the admin UI's import results.