Skip to content

fix(admin): center loading spinner under logo on login page#604

Merged
ascorbic merged 3 commits intoemdash-cms:mainfrom
all3f0r1:fix/boot-loader-spinner-centering-589
Apr 17, 2026
Merged

fix(admin): center loading spinner under logo on login page#604
ascorbic merged 3 commits intoemdash-cms:mainfrom
all3f0r1:fix/boot-loader-spinner-centering-589

Conversation

@all3f0r1
Copy link
Copy Markdown
Contributor

What does this PR do?

The Kumo <Loader /> SVG wasn't visually centered under the logo on the login page loading state. Tailwind's Preflight sets SVGs to display: block, so text-align: center on the parent had no effect. Switched the wrapper to a flex column layout with items-center for reliable centering.

Closes #589

Type of change

  • Bug fix
  • Feature (requires maintainer-approved Discussion)
  • Refactor (no behavior change)
  • Translation
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • User-visible strings in the admin UI are wrapped for translation and pnpm locale:extract has been run (if applicable)
  • I have added a changeset (if this PR changes a published package)
  • New features link to an approved Discussion: https://github.com/emdash-cms/emdash/discussions/...

AI-generated code disclosure

  • This PR includes AI-generated code

Screenshots / test output

CSS-only change — the wrapper div switches from text-center (which doesn't center block-level SVGs) to flex flex-col items-center (which does).

…dash-cms#589)

Tailwind Preflight sets SVGs to display:block, so text-align:center
on the parent didn't center the Kumo <Loader /> SVG. Switch to flex
column layout with items-center for reliable centering.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 16, 2026

🦋 Changeset detected

Latest commit: 3bd9a86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@emdash-cms/admin Patch
emdash Patch
@emdash-cms/cloudflare Patch
@emdash-cms/auth Patch
@emdash-cms/blocks Patch
@emdash-cms/gutenberg-to-portable-text Patch
@emdash-cms/x402 Patch
create-emdash Patch
@emdash-cms/plugin-embeds Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 16, 2026

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@604

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@604

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@604

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@604

emdash

npm i https://pkg.pr.new/emdash@604

create-emdash

npm i https://pkg.pr.new/create-emdash@604

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@604

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@604

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@604

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@604

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@604

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@604

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@604

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@604

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@604

commit: 3bd9a86

Copy link
Copy Markdown
Collaborator

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ascorbic ascorbic merged commit 39d285e into emdash-cms:main Apr 17, 2026
26 checks passed
@emdashbot emdashbot bot mentioned this pull request Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] loading spinner under logo is not justified center

2 participants