revert: undo accidental major and prevent recurrence#796
Merged
Conversation
Reverts 46f3acb (ci: release #759), which bumped all 8 publishable packages to 1.0.0. Restores 0.7.x versions and pending changesets so the next release lands at 0.8.0. Root cause: peer-dep cycle between `emdash` and `@emdash-cms/auth-atproto`, both using `workspace:*`. Changesets resolves `workspace:*` to the exact current version for semver checks, so a minor bump on either side falls outside the range and escalates the cycle's other side to major. Other plugins use `workspace:>=X.Y.Z` and don't trip this — switching both ends of the cycle to the same form fixes the escalation. The existing workflow guard greps `pnpm changeset status` for "bumped at major", which only runs at PR-creation time. Once the version PR is merged, no changesets are pending and the grep returns nothing — so the publish step proceeded with already-bumped 1.0.0 versions. Replaces it with a package.json scan that fails on any non-private 1.x version. Wired into both `release.yml` (publish-time) and `ci.yml` (every PR, including the auto-generated Version Packages PR). Also adds .claude/* to .gitignore (mirroring the .opencode pattern) so local agent state doesn't accidentally land in commits.
🦋 Changeset detectedLatest commit: 1a4f8cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
area/admin
area/auth
area/ci
area/cloudflare
area/core
area/plugins
size/XL
labels
Contributor
Scope checkThis PR changes 508 lines across 69 files. Large PRs are harder to review and more likely to be closed without review. If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs. See CONTRIBUTING.md for contribution guidelines. |
ascorbic
changed the title
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-perf-coordinator | 1a4f8cc | Apr 27 2026, 07:50 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| 🔵 In progress View logs |
emdash-i18n | 1a4f8cc | Apr 27 2026, 07:50 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | 1a4f8cc | Apr 27 2026, 07:51 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-demo-cache | 1a4f8cc | Apr 27 2026, 07:51 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-playground | 1a4f8cc | Apr 27 2026, 07:52 PM |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
Merged
0aveRyan
pushed a commit
to 0aveRyan/emdash
that referenced
this pull request
Apr 27, 2026
* revert: undo accidental 1.0.0 release; prevent recurrence Reverts 46f3acb (ci: release emdash-cms#759), which bumped all 8 publishable packages to 1.0.0. Restores 0.7.x versions and pending changesets so the next release lands at 0.8.0. Root cause: peer-dep cycle between `emdash` and `@emdash-cms/auth-atproto`, both using `workspace:*`. Changesets resolves `workspace:*` to the exact current version for semver checks, so a minor bump on either side falls outside the range and escalates the cycle's other side to major. Other plugins use `workspace:>=X.Y.Z` and don't trip this — switching both ends of the cycle to the same form fixes the escalation. The existing workflow guard greps `pnpm changeset status` for "bumped at major", which only runs at PR-creation time. Once the version PR is merged, no changesets are pending and the grep returns nothing — so the publish step proceeded with already-bumped 1.0.0 versions. Replaces it with a package.json scan that fails on any non-private 1.x version. Wired into both `release.yml` (publish-time) and `ci.yml` (every PR, including the auto-generated Version Packages PR). Also adds .claude/* to .gitignore (mirroring the .opencode pattern) so local agent state doesn't accidentally land in commits. * style: format * chore: update lockfile for workspace range changes --------- Co-authored-by: emdashbot[bot] <emdashbot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reverts
46f3acb(ci: release#759), which bumped all 8 publishable packages to 1.0.0 from minor changesets, and prevents the same failure mode from recurring.Root cause: peer-dep cycle between
emdashand@emdash-cms/auth-atproto, both declaring each other withworkspace:*. Changesets resolvesworkspace:*to the exact current version for semver checks, so a minor bump on either side falls outside the range and escalates the cycle's other side to major. Every other plugin usesworkspace:>=X.Y.Zand doesn't trip this — switching both ends of the cycle to the same form fixes the escalation.The existing workflow guard greps
pnpm changeset statusfor "bumped at major", which only runs on the initial workflow trigger. Once the version PR is merged, no changesets are pending and the grep returns nothing — so publish proceeded with already-bumped 1.0.0 versions. Replaced with a package.json scan that fails on any non-private 1.x version, wired into bothrelease.yml(publish-time) andci.yml(every PR, including the auto-generated Version Packages PR).Verified locally:
pnpm changeset statusnow reportsNO packages to be bumped at major— next release lands at 0.8.0.Closes #
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.AI-generated code disclosure
Screenshots / test output
`pnpm changeset status` after this PR's changes:
```
🦋 info Packages to be bumped at patch:
🦋 - @emdash-cms/plugin-atproto
🦋 - @emdash-cms/plugin-embeds
🦋 - @emdash-cms/fixture-perf-site
🦋 - @emdash-cms/perf-demo-site
🦋 - @emdash-cms/cache-demo-site
🦋 ---
🦋 info Packages to be bumped at minor:
🦋 - @emdash-cms/admin
🦋 - @emdash-cms/blocks
🦋 - emdash
🦋 - create-emdash
🦋 - @emdash-cms/auth
🦋 - @emdash-cms/auth-atproto
🦋 - @emdash-cms/cloudflare
🦋 - @emdash-cms/gutenberg-to-portable-text
🦋 - @emdash-cms/x402
🦋 ---
🦋 info NO packages to be bumped at major
```