Skip to content

feat: rtl style improvements - direction visuals improvements and usage updates#814

Merged
ascorbic merged 8 commits intoemdash-cms:mainfrom
arashackdev:feature/rtl-style-improvements
Apr 28, 2026
Merged

feat: rtl style improvements - direction visuals improvements and usage updates#814
ascorbic merged 8 commits intoemdash-cms:mainfrom
arashackdev:feature/rtl-style-improvements

Conversation

@arashackdev
Copy link
Copy Markdown
Contributor

@arashackdev arashackdev commented Apr 28, 2026

What does this PR do?

General improvements for emdash admin and some other packages to be compatible with ltr/rtl direction. Related to this discussion: #145 (comment)

Also covers arrow and caret direction respecting chosen language direction.

So overall:

  • Updates directional tailwind codes for left/right to start/end and related changes.
  • Updates arrow and caret usage on left/right directions, to follow ltr/rtl directions.

Type of change

  • Bug fix
  • Feature (requires maintainer-approved)
  • Refactor (no behavior change)
  • cms/emdash/discussions/categories/ideas))
  • Translation
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Note: a little chore due to ArrowLeft and CaretLeft being deprecated; The updated usage is ArrowLeftIcon and CaretLeftIcon.

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • User-visible strings in the admin UI are wrapped for translation (if applicable). Do not include messages.po changes except in translation PRs — a workflow extracts catalogs on merge to main.
  • I have added a changeset (if this PR changes a published package)
  • New features link to an approved Discussion: https://github.com/emdash-cms/emdash/discussions/...

AI-generated code disclosure

  • This PR includes AI-generated code (implementation in bits)

Screenshots / Test Output

Screenshot 2026-04-28 at 19 23 34
Screenshot 2026-04-28 at 19 23 54
Screenshot 2026-04-28 at 19 24 21

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 28, 2026

🦋 Changeset detected

Latest commit: 278979f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@emdash-cms/plugin-ai-moderation Minor
@emdash-cms/plugin-color Minor
@emdash-cms/plugin-forms Minor
@emdash-cms/blocks Minor
@emdash-cms/admin Minor
@emdash-cms/perf-demo-site Patch
@emdash-cms/cache-demo-site Patch
emdash Minor
@emdash-cms/plugin-embeds Patch
@emdash-cms/cloudflare Minor
@emdash-cms/fixture-perf-site Patch
@emdash-cms/auth Minor
@emdash-cms/gutenberg-to-portable-text Minor
@emdash-cms/x402 Minor
create-emdash Minor
@emdash-cms/auth-atproto Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

Scope check

This PR touches 33 files. PRs with a broad scope are harder to review. Please confirm the scope hasn't drifted beyond the intended change.

If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs.

See CONTRIBUTING.md for contribution guidelines.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 28, 2026

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@814

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@814

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@814

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@814

emdash

npm i https://pkg.pr.new/emdash@814

create-emdash

npm i https://pkg.pr.new/create-emdash@814

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@814

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@814

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@814

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@814

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@814

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@814

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@814

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@814

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@814

commit: 278979f

@arashackdev arashackdev changed the title (feature) rtl direction visuals improvements and updates feat: rtl style improvements - direction visuals improvements and usage updates Apr 28, 2026
@arashackdev arashackdev marked this pull request as ready for review April 28, 2026 17:26
@emdashbot
Copy link
Copy Markdown
Contributor

emdashbot Bot commented Apr 28, 2026

Could not push formatting changes to this fork. The contributor may have "Allow edits by maintainers" disabled.

Please run the formatter locally:

pnpm format

Copy link
Copy Markdown
Collaborator

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for doing this

@ascorbic ascorbic merged commit a838000 into emdash-cms:main Apr 28, 2026
32 checks passed
@emdashbot emdashbot Bot mentioned this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants