Merged
Conversation
Co-authored-by: ascorbic <ascorbic@users.noreply.github.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-perf-coordinator | e290ccd | Apr 30 2026, 01:32 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-i18n | e290ccd | Apr 30 2026, 01:32 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-demo-cache | e290ccd | Apr 30 2026, 01:33 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | e290ccd | Apr 30 2026, 01:33 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-playground | e290ccd | Apr 30 2026, 01:33 PM |
🦋 Changeset detectedLatest commit: e290ccd The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
Contributor
PR template validation failedPlease fix the following issues by editing your PR description:
See CONTRIBUTING.md for the full contribution policy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The issue reporter selected Cloudflare Workers in the CLI, where
blankwas never listed (onlyblog,starter,marketing,portfolioexist for Cloudflare). Theblankentry only appeared in the Node.js path. The maintainer's resolution was to removeblankentirely —starteris the minimal-content template, on both platforms.Changes
packages/create-emdash/src/index.ts— removed theblankentry fromNODE_TEMPLATES. The picker now offers the same four templates (Blog,Starter,Marketing,Portfolio) on both Node and Cloudflare.scripts/sync-templates-repo.mjs— removed"blank"from the list of templates synced to the publicemdash-cms/templatesrepo, so the next sync will stop publishing it.packages/core/tests/integration/smoke/site-matrix-smoke.test.ts— removed thetemplates/blankentry from the runtime smoke matrix. The boot test is what was tying CI to that template; the cross-cutting "Required files" check at the bottom oftemplate-smoke.test.tswalkstemplates/*via the filesystem, so it'll just stop coveringblankif/when the directory is removed..changeset/remove-blank-template-from-cli.md—patchbump forcreate-emdashdescribing the user-facing change.Docs check
I grepped
docs/forblankreferences — the only matches are HTMLtarget="_blank"(link attributes, unrelated). The "blank template referenced in the docs" the maintainer mentioned in the second comment doesn't appear to be in the current docs site; the references that exist are all in code (CLI, sync script, smoke test) and are now removed.Out of scope but worth flagging
templates/blank/directory still exists in the monorepo. With the CLI and sync removed, it's effectively dead code — but deleting it would cascade intopnpm-lock.yaml, the@emdash-cms/template-blankpackage being removed from the workspace, and a CHANGELOG marker for that template. That feels like a separate cleanup decision; happy to do it in a follow-up if you want.packages/create-emdash/CHANGELOG.mdmentionsblankhistorically (line 49). I left that alone — it's an accurate record of what shipped in that release.template-smoke.test.ts:329says "blank template has no seed, already filtered". Still factually correct (the loop filters byexistsSync(seedPath)); didn't touch unrelated code.Lint is clean for the files I changed (the 25 pre-existing diagnostics across other files are unrelated and present on
main).Closes #238
github run