fix(i18n): correct malformed ICU plural syntax in Indonesian translation#885
Merged
ascorbic merged 2 commits intoemdash-cms:mainfrom May 1, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: cf8ab74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA (gh@ahliweb.com) |
1 similar comment
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA (gh@ahliweb.com) |
The msgstr at packages/admin/src/locales/id/messages.po:146 had invalid
ICU syntax — {#} rendered the numeric count instead of the literal #
symbol, and the one form was missing. Fixed to match the msgid
structure with proper #{1}/#{2} placeholders and both one/other forms.
ahliweb
force-pushed
the
fix/id-plural-icu-syntax
branch
from
86dc37a to
cf8ab74
Compare
Contributor
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a malformed ICU MessageFormat plural in the Indonesian (id) locale file —
packages/admin/src/locales/id/messages.po:146. The brokenmsgstrused{#}(which renders the numeric count) instead of the literal#symbol that themsgidexpects, and was missing theoneplural form.Closes #886
Type of change
Checklist
pnpm typecheckpasses — N/A (.pofile only)pnpm lintpassespnpm testpasses — N/A (translation string fix, no behavior change)pnpm formathas been runAI-generated code disclosure