Crosshairs #95
Crosshairs #95
Conversation
tmccombs
force-pushed
the
crosshairs
branch
from
d0fd300 to
b5823c9
Compare
ammgws
left a comment
ammgws
left a comment
There was a problem hiding this comment.
This is much better now! Something I always wanted to fix.
|
When moving the crosshairs between monitors, sometimes this happens: crosshairs.mp4 |
That's unfortunate. I'm not entirely sure why that happens. Reverting 0eeba3a fixes, it. That does mean we mark the outputs as dirty more often than necessary. I'd have to investigate more to see if there is a better way to handle that. |
|
By the way do you have merge permissions or does this still require @emersion's approval first? |
|
I have merge permissions, but I would like it to be reviewed by someone else before merging. |
Any luck with this? Or perhaps this could still be shipped since it doesn't seem like a showstopper, especially since crosshairs are not enabled by default. |
|
No, I haven't investigated it any more yet. (But the revert is on this branch). |
|
Ok, I think I've got better checks on when to mark outputs as dirty now. I was just missing a condition in an if statements one of the places where |
New PR is at emersion/slurp#95 now
|
This has been working well for me, thanks! |
|
@emersion any objection to merging this? |
|
@tmccombs any luck? |
|
I've resolved the conflicts. |
|
I've been using this locally for a while from a manual build and I've been super happy with it. Thanks for putting it together @tmccombs! |
And have a separate header file too.
…oordinates This simplifies rendering, since we don't have to subtract the origin of the output from the selection coordinates for each operation. This also fixes the coordinates for the crosshairs drawn on the screen. Previously, the calls to draw the crosshairs used a mix of both coordinate systems, which would work for a single output, but not for many multi-output setups.
The selection color defaults to being transparent, which is not very visible if used over a light background, at least with the default background color. I think using the border color is more useful.
In man page and help output.
|
Thank you so much for getting this over the line! |
|
Thank you, love this feature! I just have a small issue, afaik there is no way to change width/weight of the lines. |
| double aspect_ratio; // h / w | ||
|
|
||
| struct slurp_box result; | ||
| bool running; |
There was a problem hiding this comment.
Code style: this PR replaces all tabs by spaces. We use tabs, not spaces.
5 participants
This is based on #56, but has been rebased on master, and fixed some issues I found while testing (mostly around outputs that don't start at the origin).