Skip to content

Only use wasm-bindgen feature for instant when building for wasm32#2808

Merged
emilk merged 1 commit intoemilk:masterfrom
gferon:master
Mar 29, 2023
Merged

Only use wasm-bindgen feature for instant when building for wasm32#2808
emilk merged 1 commit intoemilk:masterfrom
gferon:master

Conversation

@gferon
Copy link
Contributor

@gferon gferon commented Mar 13, 2023

This had the side-effect to build instant with the js-sys,wasm-bindgen,wasm-bindgen_rs,web-sys features, which somehow doesn't bother cargo but fails to compile with bazel.

@gferon gferon mentioned this pull request Mar 13, 2023
Closed
@emilk emilk merged commit 24eccca into emilk:master Mar 29, 2023
@emilk emilk added egui-winit porblems related to winit dependencies Pull requests that update a dependency file labels Apr 18, 2023
@emilk emilk changed the title Stop pulling instant with wasm-bindgen when not building for wasm32 Onlt use wasm-bindgen feature for instant when building for wasm32 Apr 18, 2023
@emilk emilk changed the title Onlt use wasm-bindgen feature for instant when building for wasm32 Only use wasm-bindgen feature for instant when building for wasm32 Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilk emilk emilk approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file egui-winit porblems related to winit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gferon @emilk