Merged
Conversation
Contributor
Author
|
Blocked by gfx-rs/wgpu#3709 (can we get a 0.16.1? @cwfitzgerald 😇) |
Contributor
|
I don't think the right action here is to get us to downgrade, rather to get ash to upgrade. It was reverted due to Firefox not being able to use windows-rs |
Owner
|
I wonder how it wasn't caught by the |
Wumpf
approved these changes
Apr 21, 2023
Collaborator
Wumpf
left a comment
There was a problem hiding this comment.
since emil is good with libloading dupl we're good to go, changes look all straight forward. Tested web and after the fix I pushed yesterday stuff still works.
Just waiting for ci to finish, there was some hickup
emilk
reviewed
Apr 21, 2023
Owner
|
🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wgpu 0.16 has been released today: https://github.com/gfx-rs/wgpu/releases/tag/v0.16.0
Not much to do actually, just the type changes of
NonZeroU32tou32and the replacement ofTextureFormat::describewithis_srgb.