Skip to content

[wgpu] Expose wgpu::Adapter via RenderState#2954

Merged
Wumpf merged 6 commits intomasterfrom
wgpu/expose-adapter
Apr 25, 2023
Merged

[wgpu] Expose wgpu::Adapter via RenderState#2954
Wumpf merged 6 commits intomasterfrom
wgpu/expose-adapter

Conversation

@Wumpf
Copy link
Collaborator

@Wumpf Wumpf commented Apr 25, 2023

Also improved errors, docs, more code sharing and use stencil bits (no other backend seems to use those? Oo)

@Wumpf Wumpf marked this pull request as ready for review April 25, 2023 12:42
@Wumpf Wumpf force-pushed the wgpu/expose-adapter branch from 69782cb to f8ef210 Compare April 25, 2023 12:42
emilk
emilk previously requested changes Apr 25, 2023
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the unwrap!

@Wumpf Wumpf dismissed emilk’s stale review April 25, 2023 15:42

all addressed

@Wumpf Wumpf merged commit f76eefb into master Apr 25, 2023
@Wumpf Wumpf deleted the wgpu/expose-adapter branch April 25, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants