eframe::Frame::info returns a reference#3301
Merged
emilk merged 6 commits intoemilk:masterfrom Sep 5, 2023
Barugon:info_ref
Merged
eframe::Frame::info returns a reference#3301emilk merged 6 commits intoemilk:masterfrom Barugon:info_ref
eframe::Frame::info returns a reference#3301emilk merged 6 commits intoemilk:masterfrom
Barugon:info_ref
Conversation
emilk
reviewed
Sep 4, 2023
| /// Get `IntegrationInfo` as a reference. | ||
| pub fn info_ref(&self) -> &IntegrationInfo { | ||
| &self.info | ||
| } |
Owner
There was a problem hiding this comment.
Let's just change the old function to return a reference instead. Users can just call .clone() themselves.
emilk
approved these changes
Sep 5, 2023
emilk
changed the title
info_ref method to Frameeframe::Frame::info returns a reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a way to get
IntegrationInfoas a reference in order to avoid a deep copy.