Remove Function() invocation from eframe text_agent to bypass "unsafe-eval" restrictions in Chrome browser extensions.#3349
Merged
emilk merged 2 commits intoemilk:masterfrom Sep 17, 2023
Conversation
emilk
approved these changes
Sep 17, 2023
emilk
approved these changes
Sep 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small snippet that replaces
Function()withcall_after_delay()(which was conveniently present a few lines below).Chrome browser extensions using the latest manifest v3 format do not allow invocation of
eval()-like functions (Functionbelongs to this list of restrictions). As such, loadingeframeWASM application within a Chrome browser extension popup will result in Chrome blocking the execution.After this change, the resulting eframe WASM application powers up as a Chrome browser extension.