Fix not taking clipping into account when calculating colum remainder#3357
Merged
emilk merged 1 commit intoemilk:masterfrom Sep 18, 2023
Merged
Fix not taking clipping into account when calculating colum remainder#3357emilk merged 1 commit intoemilk:masterfrom
emilk merged 1 commit intoemilk:masterfrom
Conversation
emilk
approved these changes
Sep 18, 2023
Owner
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
This looks right to me - thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is a problem with
Column::remainder()in that it can only grow but not shrink, even ifColumn::clip()was set. It seemed to me that a check forColumn::clip()was simply missing, but maybe I've missed the reason why this check was not there in the first place?See #2430 for more info and examples.
Tablefrom egui_extras #2430.