Change Arc<glow::Context> to Rc<glow::Context>#3598
Merged
Conversation
This is required for Rust 1.72 (for unknown reasons), but also for the glow 0.13
surban
added a commit
to surban/egui
that referenced
this pull request
Nov 26, 2023
This reverts commit 7abf8af.
This was referenced Nov 27, 2023
bagavi
pushed a commit
to bagavi/three-d
that referenced
this pull request
Nov 29, 2023
bagavi
pushed a commit
to bagavi/three-d
that referenced
this pull request
Nov 29, 2023
1. Used Rc instead of Arc in Context to make it compatible with egui emilk/egui#3598
bagavi
pushed a commit
to bagavi/three-d
that referenced
this pull request
Nov 29, 2023
1. Used Rc instead of Arc in Context to make it compatible with egui emilk/egui#3598
bagavi
pushed a commit
to bagavi/three-d
that referenced
this pull request
Dec 2, 2023
1. Used Rc instead of Arc in Context to make it compatible with egui emilk/egui#3598
marshray
pushed a commit
to marshray/surban.egui
that referenced
this pull request
Dec 4, 2023
This reverts commit 7abf8af.
emilk
pushed a commit
that referenced
this pull request
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for Rust 1.72 (for unknown reasons; see #3595), but also for updating to glow 0.13, where the
glow::Contextis not longerSync+Send