egui_extras: Add more years for datepicker#3599
Merged
emilk merged 1 commit intoemilk:masterfrom Nov 28, 2023
Merged
Conversation
Birthdates really needed this
Contributor
|
It seems it is better to add a setting to the widget rather than trying to guess best value for everyone... |
Contributor
Author
|
The change proposed in this PR is just a temporary, instant fix. I don't think there's a reason not to have 100 years, as it will cover most use-cases including birthdates. I'll be adding a full range option soon, too, though. |
emilk
approved these changes
Nov 28, 2023
emilk
changed the title
1 task
emilk
pushed a commit
that referenced
this pull request
Jun 16, 2025
…citly (#7061) Add the ability to set the `DatePickerButton`'s start and end years via new `start_year` and `end_year` methods. Continue to use the existing today - 100 years and today + 10 years behavior if a year is not specified. * This more fully closes <#3597> and expands on <#3599>. * [x] I have followed the instructions in the PR template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Birthdates really needed this
Kinda closes #3597.