Add support for dashed lines with offset#3720
Merged
emilk merged 2 commits intoemilk:masterfrom Dec 23, 2023
Merged
Conversation
oscargus
force-pushed
the
dashedlinewithoffset
branch
from
638f5cb to
7339bdd
Compare
oscargus
force-pushed
the
dashedlinewithoffset
branch
from
7339bdd to
ac4e0e8
Compare
emilk
approved these changes
Dec 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3677.
This can naturally be obtained by starting the drawing a bit "later", but providing support for this directly will simplify interleaved drawing of dashed lines.
An even more general approach would be to allow passing an even-length vector of lengths and gaps, in addition to offset. Primarily thinking if it is better to go even further if a new dashed-line-method is introduced. The second commit introduce this (I can naturally squash these!).