Added ability to disable highlighting of weekend days in DatePickerPopup.#4151
Merged
emilk merged 6 commits intoemilk:masterfrom Mar 21, 2024
Merged
Conversation
Added 'highlight_weekends' field and setter.
Added check for 'highlight_weekends' when drawing calendar.
Added 'highlight_weekends' to creation of popup struct.
emilk
approved these changes
Mar 12, 2024
Owner
|
requires rustfmt |
Contributor
Author
|
I thought I had done it properly, but I somehow managed to slip an extra space in there. |
Restored return expression in `highlight_weekends` that was removed by previous commit.
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
…pup. (emilk#4151) I added a handfull of lines to allow for the red highlight on weekends in `DatePickerPopup` to be disabled. I tried to follow the rules, but I've never done any kind of PR before, and I'm also not sure if this is at all the kind of thing that is wanted at the moment. If it is not, I'm happy to just have this removed. Just a tiny little addition I would find useful. --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a handfull of lines to allow for the red highlight on weekends in
DatePickerPopupto be disabled.I tried to follow the rules, but I've never done any kind of PR before, and I'm also not sure if this is at all the kind of thing that is wanted at the moment. If it is not, I'm happy to just have this removed. Just a tiny little addition I would find useful.