Option to change date picker format#4180
Merged
emilk merged 3 commits intoemilk:masterfrom Mar 20, 2024
Merged
Conversation
emilk
approved these changes
Mar 17, 2024
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Contributor
Author
|
Okay, applied the changes. Why did the CI fail though? |
Contributor
Author
|
Ran the script on my side, seems to work now. |
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
Simply allows date picker buttons to show other formats than `%Y-%m-%d`, while keeping that as default to not break compatibility. I'm not that experienced with Rust, so I was unsure whether you'd prefer `&'a str` rather than a `String`, let me know if I should change that. --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply allows date picker buttons to show other formats than
%Y-%m-%d, while keeping that as default to not break compatibility.I'm not that experienced with Rust, so I was unsure whether you'd prefer
&'a strrather than aString, let me know if I should change that.