egui-wgpu: Ensure that WgpuConfiguration is Send + Sync#4803
Merged
emilk merged 2 commits intoemilk:masterfrom Jul 8, 2024
Merged
egui-wgpu: Ensure that WgpuConfiguration is Send + Sync#4803emilk merged 2 commits intoemilk:masterfrom
egui-wgpu: Ensure that WgpuConfiguration is Send + Sync#4803emilk merged 2 commits intoemilk:masterfrom
Conversation
emilk
approved these changes
Jul 8, 2024
Owner
There was a problem hiding this comment.
Makes sense, but please add a test too so we don't regress! You can follow this template:
https://github.com/emilk/egui/blob/f9476e0a00a6622d2f01b56964bba9e97fd065ed/crates/egui/src/context.rs#L3468-L3473
Contributor
Author
done! |
emilk
approved these changes
Jul 8, 2024
emilk
changed the title
egui-wgpu: Ensure that WgpuConfiguration is Send + Syncegui-wgpu: Ensure that WgpuConfiguration is Send + Sync
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
…4803) As far as I can tell, there's no reason that this shouldn't be the case
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
…4803) As far as I can tell, there's no reason that this shouldn't be the case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell, there's no reason that this shouldn't be the case