Change default max_scroll_height of egui::Table to f32::INFINITY#4817
Merged
Change default max_scroll_height of egui::Table to f32::INFINITY#4817
max_scroll_height of egui::Table to f32::INFINITY#4817Conversation
lucasmerlin
pushed a commit
to lucasmerlin/egui
that referenced
this pull request
Jul 30, 2024
emilk#4817) `egui::Table` has a weirdly specific default `max_scroll_height` set to 800.0. This means that even with `vscroll(true)` and `auto_shrink([_, false])`, the table will not expend to the full available height. This PR changes this value to `f32::INFINITY`. This makes it consistent with the corresponding default value of `ScrollArea::max_size.y`, which is where that `max_scroll_height` ends up being used.
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
emilk#4817) `egui::Table` has a weirdly specific default `max_scroll_height` set to 800.0. This means that even with `vscroll(true)` and `auto_shrink([_, false])`, the table will not expend to the full available height. This PR changes this value to `f32::INFINITY`. This makes it consistent with the corresponding default value of `ScrollArea::max_size.y`, which is where that `max_scroll_height` ends up being used.
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
emilk#4817) `egui::Table` has a weirdly specific default `max_scroll_height` set to 800.0. This means that even with `vscroll(true)` and `auto_shrink([_, false])`, the table will not expend to the full available height. This PR changes this value to `f32::INFINITY`. This makes it consistent with the corresponding default value of `ScrollArea::max_size.y`, which is where that `max_scroll_height` ends up being used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
egui::Tablehas a weirdly specific defaultmax_scroll_heightset to 800.0. This means that even withvscroll(true)andauto_shrink([_, false]), the table will not expend to the full available height. This PR changes this value tof32::INFINITY. This makes it consistent with the corresponding default value ofScrollArea::max_size.y, which is where thatmax_scroll_heightends up being used.