Make sure SVGs are crisp#4823
Merged
emilk merged 2 commits intoemilk:masterfrom Jul 15, 2024
aurexav:master_
Merged
Conversation
Contributor
Author
|
It's interesting that some of the indents are tabs while others are 4-spaces. Would you like me to fix that? |
emilk
approved these changes
Jul 14, 2024
Owner
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
Looks good!
But the (false, false) => branch in fn hint should also fall back to Scale(pixels_per_point).
It would also be good to add a comment to SizeHint that its units are in image texels, and that pixels_per_point has already been taken into account.
lucasmerlin
pushed a commit
to lucasmerlin/egui
that referenced
this pull request
Jul 30, 2024
<!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * The PR title is what ends up in the changelog, so make it descriptive! * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo for it to `egui_demo_lib`, or a new example. * Do NOT open PR:s from your `master` branch, as that makes it hard for maintainers to test and add commits to your PR. * Remember to run `cargo fmt` and `cargo clippy`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! I will review your PR, but my time is limited! --> * Closes emilk#3453 * [x] I have followed the instructions in the PR template I'm fairly new to egui. I read the code, but I didn't follow the approach mentioned in emilk#3453 (comment). I believe this is an easier way to achieve that, though I'm not certain if it's the best method. <img width="760" alt="image" src="https://github.com/user-attachments/assets/4b3c561f-1c24-446b-9581-a2f4e9858480"> I get really nice svg with this patch. @emilk Can you please take a look? I really need this!
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
<!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * The PR title is what ends up in the changelog, so make it descriptive! * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo for it to `egui_demo_lib`, or a new example. * Do NOT open PR:s from your `master` branch, as that makes it hard for maintainers to test and add commits to your PR. * Remember to run `cargo fmt` and `cargo clippy`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! I will review your PR, but my time is limited! --> * Closes emilk#3453 * [x] I have followed the instructions in the PR template I'm fairly new to egui. I read the code, but I didn't follow the approach mentioned in emilk#3453 (comment). I believe this is an easier way to achieve that, though I'm not certain if it's the best method. <img width="760" alt="image" src="https://github.com/user-attachments/assets/4b3c561f-1c24-446b-9581-a2f4e9858480"> I get really nice svg with this patch. @emilk Can you please take a look? I really need this!
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
<!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * The PR title is what ends up in the changelog, so make it descriptive! * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo for it to `egui_demo_lib`, or a new example. * Do NOT open PR:s from your `master` branch, as that makes it hard for maintainers to test and add commits to your PR. * Remember to run `cargo fmt` and `cargo clippy`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! I will review your PR, but my time is limited! --> * Closes emilk#3453 * [x] I have followed the instructions in the PR template I'm fairly new to egui. I read the code, but I didn't follow the approach mentioned in emilk#3453 (comment). I believe this is an easier way to achieve that, though I'm not certain if it's the best method. <img width="760" alt="image" src="https://github.com/user-attachments/assets/4b3c561f-1c24-446b-9581-a2f4e9858480"> I get really nice svg with this patch. @emilk Can you please take a look? I really need this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ctx.pixel_per_pointis not equal to 1.0 #3453I'm fairly new to egui.
I read the code, but I didn't follow the approach mentioned in #3453 (comment).
I believe this is an easier way to achieve that, though I'm not certain if it's the best method.
I get really nice svg with this patch.
@emilk Can you please take a look? I really need this!