Skip to content

egui-wgpu: Fix docs.rs build#5204

Merged
Wumpf merged 1 commit intomasterfrom
lucas/5202-egui-wgpu-docs-build-is-failing-since-029
Oct 2, 2024
Merged

egui-wgpu: Fix docs.rs build#5204
Wumpf merged 1 commit intomasterfrom
lucas/5202-egui-wgpu-docs-build-is-failing-since-029

Conversation

@lucasmerlin
Copy link
Collaborator

This enables the rwh_06 feature in winit which is required to correctly build egui-wgpu

@lucasmerlin lucasmerlin requested a review from Wumpf as a code owner October 1, 2024 17:11
@lucasmerlin lucasmerlin linked an issue Oct 1, 2024 that may be closed by this pull request
@lucasmerlin lucasmerlin added docs and examples Improving and adding documentation and examples egui-wgpu dev-experience labels Oct 1, 2024
@github-actions
Copy link

github-actions bot commented Oct 1, 2024

Preview available at https://egui-pr-preview.github.io/pr/5204-lucas/5202-egui-wgpu-docs-build-is-failing-since-029
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.


## Enable [`winit`](https://docs.rs/winit) integration. On Linux, requires either `wayland` or `x11`
winit = ["dep:winit"]
winit = ["dep:winit", "winit/rwh_06"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do the same as eframe for consistency, although it's the same result in the end.

winit = { workspace = true, default-features = false, features = ["rwh_06"] }

Copy link
Collaborator Author

@lucasmerlin lucasmerlin Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking like it's already enabled for winit in eframe? 🤔

Copy link
Collaborator

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 👍

@Wumpf Wumpf merged commit 1406e87 into master Oct 2, 2024
@Wumpf Wumpf deleted the lucas/5202-egui-wgpu-docs-build-is-failing-since-029 branch October 2, 2024 17:17
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
This enables the rwh_06 feature in winit which is required to correctly
build egui-wgpu
- fixes emilk#5202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-experience docs and examples Improving and adding documentation and examples egui-wgpu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

egui-wgpu docs build is failing since 0.29

3 participants