Free textures after submitting queue instead of before with wgpu renderer#5226
Merged
emilk merged 2 commits intoemilk:masterfrom Oct 6, 2024
Merged
Free textures after submitting queue instead of before with wgpu renderer#5226emilk merged 2 commits intoemilk:masterfrom
emilk merged 2 commits intoemilk:masterfrom
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/5226-wgpu-texture-destroy-fix |
Collaborator
@Wumpf should be able to answer that question |
Wumpf
approved these changes
Oct 6, 2024
Collaborator
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
makes sense to me! 👍
I added a comment with some fineprint to further motivate the change
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
…erer (emilk#5226) * Closes emilk#5224 I'm unfamiliar with wgpu, so I'd like someone to confirm, that calling `wgpu::Texture` _after_ `wgpu::Queue::submit` is in fact the right thing to do. --------- Co-authored-by: Andreas Reich <r_andreas2@web.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm unfamiliar with wgpu, so I'd like someone to confirm, that calling
wgpu::Textureafterwgpu::Queue::submitis in fact the right thing to do.