Use proper image crate URI and MIME support detection#5324
Merged
emilk merged 2 commits intoemilk:masterfrom Nov 1, 2024
Merged
Use proper image crate URI and MIME support detection#5324emilk merged 2 commits intoemilk:masterfrom
image crate URI and MIME support detection#5324emilk merged 2 commits intoemilk:masterfrom
Conversation
emilk
approved these changes
Nov 1, 2024
|
Preview available at https://egui-pr-preview.github.io/pr/5324-image-crate-uris |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the webp supported URI test given that the webp feature would have to be enabled. I kept that webp is not supported in the other tests.
There might need to be an additional warning in the changelog that image support detection is now stricter.