Support loading images with weird urls and improve error message#5431
Merged
Support loading images with weird urls and improve error message#5431
Conversation
Collaborator
lucasmerlin
commented
Dec 4, 2024
lucasmerlin
commented
- Closes Some image urls don't load after #5324 #5341
- I have followed the instructions in the PR template
|
Preview available at https://egui-pr-preview.github.io/pr/5431-lucas/more-tolerant-images |
lucasmerlin
force-pushed
the
lucas/more-tolerant-images
branch
from
d369cbf to
3d463c3
Compare
Collaborator
Author
|
The same problem also exists for SvgLoader and GifLoader, but I think these can be fixed in a separate PR (and it's probably not so urgent to fix those, since there it's always been broken) |
This was referenced Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.