Skip to content

egui_kittest: write .old.png files when updating images#5578

Merged
emilk merged 1 commit intomasterfrom
emilk/better-kittest-diffs
Jan 3, 2025
Merged

egui_kittest: write .old.png files when updating images#5578
emilk merged 1 commit intomasterfrom
emilk/better-kittest-diffs

Conversation

@emilk
Copy link
Owner

@emilk emilk commented Jan 3, 2025

After running UPDATE_SNAPSHOTS=1 cargo test --all-features I want to compare before/after images before committing them. Now I can!

After running `UPDATE_SNAPSHOTS=1 cargo test --all-features` I want to
compare before/after images before committing them. Now I can!
@github-actions
Copy link

github-actions bot commented Jan 3, 2025

Preview available at https://egui-pr-preview.github.io/pr/5578-emilkbetter-kittest-diffs
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

Copy link
Collaborator

@lucasmerlin lucasmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@emilk emilk merged commit 938d8b0 into master Jan 3, 2025
@emilk emilk deleted the emilk/better-kittest-diffs branch January 3, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants