Web: Fix incorrect scale when moving to screen with new DPI#5631
Merged
Web: Fix incorrect scale when moving to screen with new DPI#5631
Conversation
emilk
added
bug
emilk
force-pushed
the
emilk/fix-resize-ovserver
branch
from
2cdc3a7 to
9d7e85f
Compare
|
Preview available at https://egui-pr-preview.github.io/pr/5631-emilkfix-resize-ovserver |
emilk
force-pushed
the
emilk/fix-resize-ovserver
branch
from
db7e7d0 to
12a769e
Compare
This was referenced Jan 23, 2025
emilk
added a commit
that referenced
this pull request
Jan 23, 2025
* Broke in #5631 (for _some_ apps)
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
Jan 23, 2025
### Contains these notable fixes * emilk/egui#5631 * emilk/egui#5555
Contributor
|
Glad to hear you fixed this! I hit it quite often and was about to look into it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on
On Chromium and Firefox we get one annoying frame with the wrong size, which can mess up the layout of egui apps, but this PR is still a huge improvement, and I don't want to spend more time on this right now.