Conversation
emilk
force-pushed
the
better-ui-panels
branch
from
68ead87 to
e1741fe
Compare
gents83
approved these changes
Aug 18, 2021
Contributor
gents83
left a comment
gents83
left a comment
There was a problem hiding this comment.
New functionalities allowed "hiding" to user all panels positioning - Super appreciated!
Merged
emilk
added a commit
that referenced
this pull request
Aug 26, 2021
* Fix incorrect max_width/height of panels * Fix set_width/set_min_width/set_height/set_min_height Closes #647 Broke in #629 * Fix expand_to_include_x/expand_to_include_y * Make minimum grid column width propagate properly * Expand cursor when max_rect expands * Add ui.expand_to_include_y * Only expand cursor in advance * demo: clean up font_book code * Fix: Make sure `TextEdit` contents expand to fill width if applicable * ProgressBar: minimum width and fix for having it in an infinite layout * clippy fix
mankinskin
pushed a commit
to mankinskin/egui
that referenced
this pull request
Sep 29, 2021
* Allow using the layout cursor to restrict available area * Avoid id clashes when putting panels inside a Ui * Panels: Propagate height/width range to inner Ui * Allow easy placement of panels inside of Ui:s * demo: simplify Windows with Panels demo
mankinskin
pushed a commit
to mankinskin/egui
that referenced
this pull request
Sep 29, 2021
mankinskin
pushed a commit
to mankinskin/egui
that referenced
this pull request
Sep 29, 2021
* Fix incorrect max_width/height of panels * Fix set_width/set_min_width/set_height/set_min_height Closes emilk#647 Broke in emilk#629 * Fix expand_to_include_x/expand_to_include_y * Make minimum grid column width propagate properly * Expand cursor when max_rect expands * Add ui.expand_to_include_y * Only expand cursor in advance * demo: clean up font_book code * Fix: Make sure `TextEdit` contents expand to fill width if applicable * ProgressBar: minimum width and fix for having it in an infinite layout * clippy fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #624 to improve the ergonomics of sticking panels inside of a Ui.
PTAL @gents83