Include popups and tooltips in Harness::fit_contents#7556
Merged
lucasmerlin merged 5 commits intomainfrom Sep 23, 2025
Merged
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/7556-gijsimprove-fit-contents |
lucasmerlin
reviewed
Sep 22, 2025
emilk
approved these changes
Sep 22, 2025
Owner
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
Would be nice with an actual snapshot test to test this
Comment on lines
+281
to
+286
| // Start with the standard response rect | ||
| let mut used = if let Some(response) = self.response.as_ref() { | ||
| response.rect | ||
| } else { | ||
| return None; | ||
| }; |
Owner
There was a problem hiding this comment.
alternative, that will still work in case of no response, but when there are areas. Though needs handling in case there are no areas
Suggested change
| // Start with the standard response rect | |
| let mut used = if let Some(response) = self.response.as_ref() { | |
| response.rect | |
| } else { | |
| return None; | |
| }; | |
| // Start with the standard response rect | |
| let mut used = if let Some(response) = self.response.as_ref() { | |
| response.rect | |
| } else { | |
| Rect::NOTHING | |
| }; |
Collaborator
Author
There was a problem hiding this comment.
I want to retain the current behavior in case of no response.
lucasmerlin
reviewed
Sep 23, 2025
podusowski
pushed a commit
to podusowski/egui
that referenced
this pull request
Oct 10, 2025
This makes `Harness::fit_contents` also use popups and tooltips to compute the size of the contents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
Harness::fit_contentsalso use popups and tooltips to compute the size of the contents.