Make Galley::pos_from_layout_cursor pub#7864
Merged
emilk merged 1 commit intoemilk:mainfrom Mar 3, 2026
Merged
Conversation
|
Preview is being built... Preview will be available at https://egui-pr-preview.github.io/pr/7864-expose-pos_from_layout_cursor View snapshot changes at kitdiff |
emilk
approved these changes
Mar 3, 2026
emilk
changed the title
Galley::pos_from_layout_cursor pub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just exposes the pos_from_layout_cursor function as public.
Hi, I'm trying to make a git gui with a merge editor, and for this I need a much more efficient and flexible text editor than the one currently in egui. So I'm working on building a more suitable one, which I intend to contribute back once it's working, but for now I would like to not need to fork the entirety of egui. By exposing this one function I (and others) can much more easily reuse Galleys.
I suggest also exposing end_pos, but I'm not currently using that. Let me know if I should update this PR to do so.
Thanks for the otherwise awesome tool :)