Skip to content

Fix invalid setting type #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Fix invalid setting type #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions lib/inputstreamhelper/kodiutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,14 +193,11 @@ def get_setting_int(key, default=None):

def get_setting_float(key, default=None):
"""Get an add-on setting as float"""
value = get_setting(key, default)
try:
return ADDON.getSettingNumber(key)
except (AttributeError, TypeError): # On Krypton or older, or when not a float
value = get_setting(key, default)
try:
return float(value)
except ValueError:
return default
return float(value)
except ValueError:
return default
except RuntimeError: # Occurs when the add-on is disabled
return default

Expand Down
6 changes: 3 additions & 3 deletions resources/settings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>
<settings>
<setting id="last_modified" value="0.0" visible="false"/>
<setting id="last_check" value="0.0" visible="false"/>
<setting id="version" value="" visible="false"/>
<category label="30900"> <!-- Expert -->
<setting id="last_modified" default="0.0" visible="false"/>
<setting id="last_check" default="0.0" visible="false"/>
<setting id="version" default="" visible="false"/>
<setting label="30901" help="30902" type="action" action="RunScript(script.module.inputstreamhelper, info)"/>
<setting type="sep"/>
<setting label="30903" help="30904" type="bool" id="disabled" default="false"/>
Expand Down