Implement case insensitive literals for Pydantic models #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add direct tests for the inner validator function from case_insensitive_literal_validator, including type and value error cases. - Assert that the returned validator is a PlainValidator instance. - Ensure all case-insensitive variants are tested for canonical value mapping. - Add/clarify docstrings and comments for test clarity. - Retain and verify Pydantic model integration and error handling.
Only place we still use Literal is for tagged discriminators in pydantic. This is because pydantic requires enum or literal for the discriminator type. For these, we don't want case insensitive behavior.
Owner
Author
|
Used copilot agent mode and github code environment to create this while watching some dota2.. Interesting that it worked okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a
CaseInsensitiveLiteraltype to enhance Pydantic model validation by allowing case-insensitive string matching for defined literal values. Improve documentation and tests for the new functionality while ensuring existing integrations remain intact. Clean up test cases and resolve type variable errors.