Skip to content

Comments

Gnk track offset#154

Merged
emoon merged 3 commits intoemoon:masterfrom
gnilk:gnk_track_offset
Sep 6, 2020
Merged

Gnk track offset#154
emoon merged 3 commits intoemoon:masterfrom
gnilk:gnk_track_offset

Conversation

@gnilk
Copy link
Contributor

@gnilk gnilk commented Sep 5, 2020

Seems like it's not possible to implement track offset the way I naively expected. One can't interleave delete/add operations for adjacent keys. This patch fix this plus implements a few new more features.

FIX: Offset for adjacent keys causing unexpected results
NEW: CMD+K/L Offset keys of single track with +/- 8 rows
NEW: CTRL+K/L Offset all keys in group with +/- 8 rows

gnilk and others added 3 commits August 10, 2020 09:17
Mapped keyboard K and L to offset (+/- 1) all keys in the current track.
FIX: Track offset bug for adjacent keys
NEW: Track offset with +8 rows
NEW: Group offset (all tracks in a group) -> +8 rows
@emoon emoon merged commit 266c08c into emoon:master Sep 6, 2020
EDITOR_MENU_BIAS_P_1000,
EDITOR_MENU_BIAS_N_001,
EDITOR_MENU_BIAS_N_01,
EDITOR_MENU_BIAS_N_01,https://github.com/emoon/rocket

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right.

@emoon
Copy link
Owner

emoon commented Nov 29, 2020

@fritschy indeed, fixed in 521e3cf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants