Overwrite packages during consolidation step#6
Merged
RoboDoig merged 3 commits intoemotional-cities:mainfrom Sep 26, 2023
Merged
Overwrite packages during consolidation step#6RoboDoig merged 3 commits intoemotional-cities:mainfrom
RoboDoig merged 3 commits intoemotional-cities:mainfrom
Conversation
This is the safer option as any dependency changes in the Bonsai editor will now be updated during the consolidate packages step, even if they are already included in the Unity packages.
glopesdev
approved these changes
Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #4. Previously, during the package consolidation step, the BonsaiWorkflowEditor script would only copy new packages from the Bonsai environment, i.e. those with a name that was not present in the Unity packages. This meant that updates to existing Bonsai packages from the editor would be ignored in the Unity packages. The safer option is just to overwrite all packages so that the Unity packages are guaranteed to match those in the Bonsai installation.