Skip to content

Conversation

@chuxmykel
Copy link
Collaborator

What does this PR do?

This PR integrates PostgreSQL as the project database using sequelize as an ORM. It also provides scripts for running basic database operations such as migrations and seeding.

Description of Task to be completed?

  • install sequelize as ORM and sequelize-cli for operations
  • add users migrations and models for table creation and DB interaction
  • update .env.sample file to contain database URL
  • add database related scripts
  • update README.md file to describe new database scripts

How should this be manually tested?

  • clone the REPO cd into the directory and create a .env file from the .env.sample file provided
  • run npm install
  • follow the migrations guide on the README.md file to run different operations on the DB

Any background context you want to provide?

  • None

What are the relevant pivotal tracker stories?

#166265830

Screenshots (if appropriate)

Screenshot from 2019-05-29 12-26-13
Screenshot from 2019-05-29 12-25-03
Screenshot from 2019-05-29 12-24-11
Screenshot from 2019-05-29 12-24-05

- install sequelize as ORM and sequelize-cli for operations
- add users migrations and models for table creation and db interaction
- update .env.sample file to contain database url
- add database related scripts
- update README.md file to describe new database scripts

[Delivers #166265830]
@@ -0,0 +1,25 @@
'use strict';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chuxmykel chuxmykel requested a review from cvjude May 29, 2019 11:40
@chuxmykel chuxmykel requested a review from emp-daisy May 29, 2019 13:32
Copy link
Collaborator

@OvieMudi OvieMudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is Hound CI nagging when you used built-in Node variables/functions like __dirname, require etc?

@chuxmykel
Copy link
Collaborator Author

@OvieMudi I have no idea. I may have to look it up

@chuxmykel
Copy link
Collaborator Author

chuxmykel commented May 29, 2019

@OvieMudi check this out
We may need to do some config in our .eslintrc file

@Hadeneekeh
Copy link
Collaborator

@chuxmykel that link is referring to the eslint configuration to add to the hound.yml file which @PelumiAlesh have taken care of.

@Hadeneekeh Hadeneekeh merged commit 68ae83f into develop May 29, 2019
Hadeneekeh added a commit that referenced this pull request May 31, 2019
…equelize

#166265830 Integrate postgreSQL as the project database
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants