#166265859 Super Admin should be able to create Users #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvjude
force-pushed
the
ft-superadmin-add-users-166265859
branch
from
c79c020 to
4c6c9e1
Compare
cvjude
requested review from
Hadeneekeh,
OvieMudi,
PelumiAlesh,
chuxmykel,
emp-daisy,
encodedBicoding and
ocranbillions
and removed request for
Hadeneekeh and
encodedBicoding
encodedBicoding
previously approved these changes
Jun 12, 2019
emp-daisy
reviewed
Jun 12, 2019
server/middleware/authenticator.js
Outdated
| * @returns {object} Json | ||
| * @memberof Controllers | ||
| */ | ||
| static async user(req, res, next) { |
Owner
There was a problem hiding this comment.
The previous name is more descriptive. Please reverse to that
emp-daisy
reviewed
Jun 12, 2019
server/controllers/userController.js
Outdated
| signupMethod | ||
| }; | ||
| } else { | ||
| const theUser = await models.Users.findAll(); |
Owner
There was a problem hiding this comment.
You do not need to map through the objects to pick what you want. You can get that done from the query.
eg:
Project.find({
attributes: ['id', 'name', 'title']
})
- Create an endpoint to for a super admin to create users - create an endpoint for Super delete users - create an endpoint for superAdmin to get all users or a single user [Delivers #166265859]
cvjude
force-pushed
the
ft-superadmin-add-users-166265859
branch
from
4c6c9e1 to
6b07a8d
Compare
cvjude
requested review from
emp-daisy and
encodedBicoding
and removed request for
emp-daisy
emp-daisy
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates endpoints for the superAdmin to create, delete and get users
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)