Conversation
|
Just a couple of things maybe worth mentioning when talking about floats:
|
|
To me, it seems very good and comprehensive overall 👍🏻 Just three comments:
|
edoardob90
left a comment
There was a problem hiding this comment.
For me it's okay overall. I left three comments. The final version can be merged without further approval
done in fc50d0c |
done in 41c0cd9 |
I don't know how to phrase this properly. I do provide an example that |
done in 69f679b
done in d6a7440 |
Added issue #38 to address it after our PRs are merged. |
done in c608fc7 |
fixed in 5b25aba |
|
@edoardob90, @baffelli I think I addressed all your comments in one way or another. Please have a look and let me know if it is okay to merge the PR. |
Well done, great text! |
I think the difference is that all numerical types belong somehow to the same type hierarchy here therefore they support implicit promotion, while strings do not belong to that hierachy. This sort of ambiguity was one of the reason for defining typeclasses in other programming languages such as haskell... |
ok, addressed in c8b24cb |
fixes #3