Skip to content

Advanced OOP#156

Merged
edoardob90 merged 15 commits intomainfrom
121-classes-advanced
Dec 11, 2023
Merged

Advanced OOP#156
edoardob90 merged 15 commits intomainfrom
121-classes-advanced

Conversation

@despadam
Copy link
Copy Markdown
Contributor

@despadam despadam commented Nov 15, 2023

fixes #121

@despadam despadam requested a review from edoardob90 December 8, 2023 23:39
@despadam despadam marked this pull request as ready for review December 8, 2023 23:39
Copy link
Copy Markdown
Member

@edoardob90 edoardob90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @despadam 👏🏻 Thorough and the exercises are very much in line with the topics you covered.

I left you a few comments on how to improve the tests.

Comment thread tutorial/tests/test_object_oriented_programming_advanced.py Outdated
Comment thread tutorial/tests/test_object_oriented_programming_advanced.py Outdated
Comment thread tutorial/tests/test_object_oriented_programming_advanced.py Outdated
Comment thread tutorial/tests/test_object_oriented_programming_advanced.py Outdated
Comment thread object_oriented_programming_advanced.ipynb
@despadam
Copy link
Copy Markdown
Contributor Author

Thanks @edoardob90 for your comments! They have all been addressed. Could you please do a last check that everything works properly?

Copy link
Copy Markdown
Member

@edoardob90 edoardob90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 💯

@edoardob90 edoardob90 merged commit 3cbf3d3 into main Dec 11, 2023
@edoardob90 edoardob90 deleted the 121-classes-advanced branch December 11, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Classes (advanced)

2 participants