Conversation
for more information, see https://pre-commit.ci
…-it/python-tutorial into new-material/parallelism
for more information, see https://pre-commit.ci
…-it/python-tutorial into new-material/parallelism
for more information, see https://pre-commit.ci
…-it/python-tutorial into new-material/parallelism
…-it/python-tutorial into new-material/parallelism
|
I set the PR "ready for review" since in fact it has been reviewed. |
Wait, there are a couple of things that should be fixed still. Some of the problems with running the code that @despadam had should be investigated. |
But "Ready for review" means only that it is ready for review, nothing more than that. We merge things only when they are approved. |
|
Yes, just reviewing for now. Not merging yet, but it shouldn't be a draft anymore. |
despadam
left a comment
There was a problem hiding this comment.
Just a small typo in the Quiz
Co-authored-by: Despina Adamopoulou <16343312+despadam@users.noreply.github.com>
|
For me the examples in the section High-level interface: Process pools cannot run. I get the following error in the console:
|
|
As agreed with @baffelli, it is best to merge and see if the examples and exercises will work on Binder, as this is the most pressing matter. It appears that the errors as OS dependent, so let's make sure that it will work online and then we can discourage the participants from running the tutorial locally, for this section at least. |
|
Let's try it here |
|
Binder is unfortunately down now, and the error @despadam mentioned happens on my two machines as well. Not sure what we can do. |
That's really unfortunate. It seems to be highly OS dependent or maybe it's just a special case that runs on VSCode with the Jupiter extension. It might be that they implement a different Ipython kernel. I hope it works on Binder tomorrow, if not I'll try to walk people through examples in order to fill at least 1.5 hours |
|
Minor changes to the text. Still, I cannot make the notebook work with any Python version I tested. I'm sure I'm missing something in the setup, but for me the entire notebook is in a "broken" state. |
Applied sugestions on text Co-authored-by: Edoardo Baldi <edoardo.baldi@empa.ch>
Closes #10