Skip to content

Added type hints.#219

Merged
baffelli merged 3 commits intomainfrom
102-add-type-hints-in-basic-data-types-exercises
Apr 30, 2024
Merged

Added type hints.#219
baffelli merged 3 commits intomainfrom
102-add-type-hints-in-basic-data-types-exercises

Conversation

@baffelli
Copy link
Copy Markdown
Member

Closes #102

@baffelli baffelli added the upcoming tutorial Stuff to work on/fix before the next tutorial label Apr 16, 2024
@baffelli baffelli linked an issue Apr 16, 2024 that may be closed by this pull request
@yakutovicha yakutovicha removed their assignment Apr 19, 2024
@yakutovicha yakutovicha self-requested a review April 19, 2024 11:48
@despadam
Copy link
Copy Markdown
Contributor

Shall we also add type hints to the reference solutions?

@yakutovicha
Copy link
Copy Markdown
Member

Shall we also add type hints to the reference solutions?

good catch, @despadam. I was about to approve it. @baffelli could you do that?

@baffelli
Copy link
Copy Markdown
Member Author

Shall we also add type hints to the reference solutions?

good catch, @despadam. I was about to approve it. @baffelli could you do that?

Done in 5551d78

yakutovicha
yakutovicha previously approved these changes Apr 30, 2024
Copy link
Copy Markdown
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly tested, seems to work fine.

I will go through a more careful check before the tutorial, in case of issues, I will update the material accordingly.

@baffelli
Copy link
Copy Markdown
Member Author

Quickly tested, seems to work fine.

I will go through a more careful check before the tutorial, in case of issues, I will update the material accordingly.

Can I merge then?

@yakutovicha
Copy link
Copy Markdown
Member

Quickly tested, seems to work fine.
I will go through a more careful check before the tutorial, in case of issues, I will update the material accordingly.

Can I merge then?

There was a problem wit the pre-commit check. I just fixed it.

@yakutovicha yakutovicha self-requested a review April 30, 2024 08:26
@yakutovicha
Copy link
Copy Markdown
Member

@baffelli now you can.

@baffelli baffelli merged commit 89d465e into main Apr 30, 2024
@baffelli baffelli deleted the 102-add-type-hints-in-basic-data-types-exercises branch April 30, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upcoming tutorial Stuff to work on/fix before the next tutorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add type hints in basic data types exercises

3 participants