Skip to content

Conversation

@eli-fidele
Copy link

Hi Emily!

I've found a neat way to contributed my revisions without breaking any of your code. Thank you so much for your permission to use your package.

I've attached a revisions folder containing two sets of script files:

  1. R-kern: this contains all the code from museR pertaining to kern scores. I don't think I changed any of the names with the exception of the following:
    Major_minor -> relative_key
    rhy_entropy -> rhythmic_entropy
    n.v_n.n -> krn_note
    A few functions were removed since they didn't work so I would advise combing through the script files to see if what is missing. I may have forgotten a function or two.

  2. R-misty: this contains an additional module with one primary function: scaleDegree(tonic, note). This function, inspired by your code drafts, takes a note and a tonic and returns the appropriate scale degree (handling enharmonic edge cases). My module for this function is kinda messy so if you're interested I'll be updating this on my mistyR package, to which you have full rights to copy and use in museR. I've attached an analysis folder as a usage example from my Data Science final.

Thank you so much, Emily! I hope you find these changes useful.

P.S. the data.R file is critical to source, it has some global variables needed by the functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant