feat: .gitignore and .qualignore support for file discovery#3
Merged
Conversation
Replace the manual walk_dir with the `ignore` crate's WalkBuilder, which respects .gitignore (including parent dirs, global, and git/info/exclude), .qualignore (custom, gitignore-compatible syntax), and adds --no-ignore to bypass all filtering. Document the feature in SPEC.md §10, README.md, and AGENTS.md.
|
🔍 Preview deployed: https://47f03cdf.qualifier-dev.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
walk_dirwith theignorecrate'sWalkBuilder, respecting.gitignore(including parent dirs, global config, andgit/info/exclude) and a new.qualignorefile (gitignore-compatible syntax)--no-ignoreflag to all discovery commands (score,show,check,ls,compact,praise/blame) to bypass ignore rules--no-ignore, Hidden Directories), README.md Core Concepts, and AGENTS.md ("Keeping Things in Sync" section)discover()API signature in SPEC.md §7 to match the actual(root, respect_ignore)signatureparents(false)so.gitignorefiles in ancestor directories are respected (correct monorepo behavior)Test plan
cargo test --all-features— all 145 tests passcargo clippy— cleancargo run -- score— nosite/orexamples/leakage.qualignorewith a pattern and verify excluded.qualfiles are skipped--no-ignoreoverrides.qualignoreand.gitignore