fix: clear five review-flagged quick wins#9
Merged
Conversation
- drop unused petgraph dep (graph engine was yanked in 0.5) - agents subcommand: return Err(Validation) for unknown topic instead of process::exit(2), so exit code is 1 with the standard "qualifier:" prefix like every other validation error - review (freshness): resolve project root from canonical CWD before discovery, and join the root with each subject when checking spans — review now works from any subdirectory - config::load returns Result; cli::run validates config eagerly and exits non-zero on malformed .qualifier.toml or QUALIFIER_* env vars - user-config path falls back to USERPROFILE when HOME is unset (Windows) Resolves annotations ccfe88fa, 436a095a, 65a84bf7, 8773c911, fe766001.
|
🔍 Preview deployed: https://66acb7f4.qualifier-dev.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes 5 of the 22 active review-flagged annotations in the repo. Each change has a regression test; the corresponding annotation has been resolved with a record explaining the fix.
Cargo.toml— drop unusedpetgraph(graph engine was yanked in 0.5).ccfe88faagentssubcommand — returnErr(Validation)for unknown topics instead ofprocess::exit(2). Exit code is now 1 with the standardqualifier:prefix that every other validation error uses.436a095areview(freshness) — resolve project root from canonical CWD before discovery, and join the root with each subject when checking span freshness.qualifier reviewnow works from any subdirectory; previously it returned "no .qual files found" except from the project root.65a84bf7config::load— now returnsResult;cli::runvalidates config eagerly and exits non-zero on malformed.qualifier.tomlorQUALIFIER_*env vars instead of silently falling back to defaults.8773c911configuser path — falls back toUSERPROFILEwhenHOMEis unset, so Windows users get the user-level config too.fe766001Two annotations called out as quick-win candidates were skipped:
da1fabb9(ls --unqualifiedstub) was kept open after second-thought — the flag answers a real "where's coverage weak?" question and should be implemented separately rather than removed.Test plan
cargo test— 195 tests pass (3 new integration tests, one per behavior change)qualifier reviewfrom a nested subdir now reports FRESH, not "no .qual files found"qualifier agents bogus-topicexits 1 withqualifier: no such topic ....qualifier.tomlcauses anyqualifiercommand to exit non-zero with a config errorqualifier reviewfrom project root shows the 5 resolved annotations dropped from the active set (22 → 17)Need help on this PR? Tag
@codesmithwith what you need.