fix(cli): resume picker requires the cursor CLI, not just open#118
Open
akesling wants to merge 1 commit into
Open
fix(cli): resume picker requires the cursor CLI, not just open#118akesling wants to merge 1 commit into
open#118akesling wants to merge 1 commit into
Conversation
`path resume`'s harness picker listed cursor whenever the macOS `open` (or Linux `xdg-open`) binary was present, via the `open -a Cursor` fallback in `harness_available`. Since `open` is always present on macOS, cursor showed in the picker even when Cursor wasn't installed. Gate every harness purely on its own binary being on PATH: `harness_available` is now just `binary_on_path(harness.name(), …)`. The macOS-only `cursor_available_via_open_fallback_on_macos` test is replaced by `cursor_requires_its_cli_not_just_open`, which asserts cursor is absent when only `open` exists and present when the real `cursor` CLI is on PATH.
|
🔍 Preview deployed: https://3509fb03.toolpath.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
path resume's harness picker listed cursor whenever the macOSopen(or Linux
xdg-open) binary was present — via theopen -a Cursorfallback inharness_available. Becauseopenis always present on macOS, cursor appearedin the picker even when Cursor wasn't installed.
This gates every harness purely on its own binary being on
PATH:harness_availablebecomes justbinary_on_path(harness.name(), …).Test
Replaces the macOS-only
cursor_available_via_open_fallback_on_macoswithcursor_requires_its_cli_not_just_open, which asserts cursor is absent whenonly
openexists and present when the realcursorCLI is onPATH.Context
Extracted from the GitHub Copilot provider PR (#117) as an independent fix — it
touches only
path resume's picker and is unrelated to the Copilot work.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.