refactor(path-cli): migrate cmd_track jsonl I/O to Graph API#68
Merged
Conversation
After 4c1ee8c the JSONL format moved from `Path::{from,to}_jsonl_*` to `Graph::{from,to}_jsonl_*` (single-path graph at the file boundary). `cmd_track` was the last consumer in path-cli still using the Path-level API. Migrate `load_session` / `save_session` and the three test sites that re-parse `.path.jsonl` session files to read through `Graph`, and refresh the now-stale doc-comment in `toolpath::v1::jsonl` that still pointed at the Path methods. No behavior change — `.path.jsonl` is still a single-path graph at the file boundary. cargo test --workspace and cargo clippy --workspace -- -D warnings both green.
|
🔍 Preview deployed: https://88e040c7.toolpath.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmd_trackwas the last consumer inpath-clistill callingv1::Path::{from,to}_jsonl_*. After 4c1ee8c the JSONL format is anchored atGraph(a single-path graph at the file boundary); migrateload_session/save_sessionand the three test sites that re-parse.path.jsonlto read/write throughGraph::{from,to}_jsonl_*(withinto_single_path/from_pathat the boundaries).toolpath::v1::jsonlthat still pointed at the Path-level methods.No behavior change:
.path.jsonlsession files are byte-identical, and the "tail-f-like" incremental-build flow (path track init/step/note/ etc.) still writes the same single-path graph stream — it just goes through the Graph API now.Test plan
cargo build --workspacecargo test --workspace(all suites green, including the 61cmd_trackunit tests)cargo clippy --workspace -- -D warnings