Skip to content

Comments

feat: make MyHistory dates locale rely on uiLang#1990

Closed
hiepau1231 wants to merge 1 commit intoempathyco:mainfrom
hiepau1231:feat/issue-791-myhistory-uilang
Closed

feat: make MyHistory dates locale rely on uiLang#1990
hiepau1231 wants to merge 1 commit intoempathyco:mainfrom
hiepau1231:feat/issue-791-myhistory-uilang

Conversation

@hiepau1231
Copy link

Description

This PR fixes #791 by making the MyHistory component use uiLang instead of lang for date formatting.

Changes

  • Updated locale resolution to prefer uiLang over lang in my-history.vue
  • Added first character capitalization to formatted dates
  • Added comprehensive test cases covering:
    • uiLang usage when provided
    • Fallback to lang when uiLang is not available
    • Date capitalization across different locales

Testing

  • All existing tests pass ✅
  • New test cases added and passing ✅
  • Linting passed ✅

Closes #791

- Changed locale resolution to prefer uiLang over lang
- Added capitalization of first character in formatted dates
- Added comprehensive test cases for uiLang usage and capitalization
- Fixes empathyco#791

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@hiepau1231 hiepau1231 requested a review from a team as a code owner February 16, 2026 00:43
@victorcg88
Copy link
Contributor

Hi @hiepau1231,

First of all, thanks for your contribution.

Please, create the PR from the original repository, not from a fork. Otherwise, the workflows won't pass.

Looking forward to that new PR.

@victorcg88 victorcg88 added invalid This doesn't seem right contributors Pull Request from external contributors labels Feb 18, 2026
@hiepau1231
Copy link
Author

Closing and reopening as requested by @victorcg88 to allow CI/CD workflows to run properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributors Pull Request from external contributors invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: My History dates locale should rely on uiLang

2 participants